tests/core/memory/gotchas-memory.test.js (2)

294-297: Sort order test only verifies critical is first — consider asserting the full order.

Since the || → ?? fix is the crux of issue #476, it would add confidence to assert the complete critical → warning → info ordering rather than just checking the first element.

🧪 Strengthen the sort-order assertion

   test('sorts critical first', () => {
     const list = m.listGotchas();
-    expect(list[0].severity).toBe(Severity.CRITICAL);
+    const severities = list.map((g) => g.severity);
+    expect(severities).toEqual([Severity.CRITICAL, Severity.WARNING, Severity.INFO]);
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/core/memory/gotchas-memory.test.js` around lines 294 - 297, Update the
"sorts critical first" test to assert the complete severity ordering instead of
only the first element: call m.listGotchas(), map the returned items to their
.severity and assert the array equals [Severity.CRITICAL, Severity.WARNING,
Severity.INFO] (and optionally assert expected length), referencing the existing
test name and the m.listGotchas and Severity.* enums to locate where to change
the assertion.

---

25-33: Temp directories are never cleaned up.

makeTmpDir() creates directories in os.tmpdir() but there's no afterAll or afterEach hook to remove them. The OS will eventually reclaim the space, but in CI environments with many test runs this can accumulate. Consider adding cleanup or using Jest's built-in temp directory support if available.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/core/memory/gotchas-memory.test.js` around lines 25 - 33, makeTmpDir()
creates temp dirs that are never removed; update the test file to track and
clean those directories after tests by recording each returned root from
makeTmpDir()/makeMemory (e.g., push into a local array) and add an afterEach or
afterAll hook that iterates the tracked paths and removes them with
fs.rmSync(root, { recursive: true, force: true }) (or fs.rmdirSync for older
Node), ensuring you reference makeTmpDir, makeMemory and GotchasMemory when
locating where to add the tracking and the cleanup hook.

.aios-core/core/memory/gotchas-memory.js (1)

186-190: Constructor options use ||, which has the same falsy-coercion issue fixed in listGotchas.

Lines 187–188 use || for repeatThreshold and errorWindowMs. If a caller ever passes 0 for either, the default will silently override their intent — the same class of bug this PR fixes at line 324. While 0 isn't a practical value for these settings today, applying ?? here would be consistent with the fix philosophy and prevent a subtle future foot-gun.

♻️ Suggested consistency fix

     this.options = {
-      repeatThreshold: options.repeatThreshold || CONFIG.repeatThreshold,
-      errorWindowMs: options.errorWindowMs || CONFIG.errorWindowMs,
+      repeatThreshold: options.repeatThreshold ?? CONFIG.repeatThreshold,
+      errorWindowMs: options.errorWindowMs ?? CONFIG.errorWindowMs,
       quiet: options.quiet || false,
     };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.aios-core/core/memory/gotchas-memory.js around lines 186 - 190, The
constructor currently sets this.options.repeatThreshold and
this.options.errorWindowMs using || which treats 0 as falsy and will override an
explicit 0; change those assignments to use the nullish coalescing operator (??)
so that only null/undefined fall back to CONFIG (mirror the fix applied in
listGotchas); update the two places where repeatThreshold and errorWindowMs are
assigned in the constructor to use ?? instead of ||, leaving the quiet default
as-is.